Icons: Deprecate warning and rename to cautionFilled
#67895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
mirka
commented
Dec 12, 2024
Comment on lines
+17
to
+18
| // Deprecated aliases | ||
| warning: _warning, |
There was a problem hiding this comment.
Omitting from the Icon Library in Storybook.
| @@ -1,13 +1,13 @@ | |||
| const keywords: Partial< Record< keyof typeof import('../../'), string[] > > = { | |||
| cancelCircleFilled: [ 'close' ], | |||
| cautionFilled: [ 'alert', 'caution', 'warning' ], | |||
There was a problem hiding this comment.
Making sure it's still findable with the search query "warning".
|
Size Change: -173 B (-0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 968437a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12315195769
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Dec 13, 2024
|
Oops, I was omitting native files from my search. Fixed in 7f1d0ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to https://github.com/WordPress/gutenberg/pull/66555/files#r1880778506
What?
Deprecates the
warningicon and renames (re-exports) it ascautionFilled.Why?
The Icons package has a convention where we have a pair of filled and unfilled icons:
The
warningicon is a filled icon, but didn't follow the naming convention:We now have a need for a corresponding "unfilled" icon, and thus should take this opportunity to streamline the naming.
Testing Instructions
warningicon should appear in the Storybook Icon Library with the new namecautionFilled.warning, but marked as deprecated in TypeScript.There are no existing usages of the
warningicon in the app (as far as my regex skills tells me), but maybe you can find some!Screenshots or screencast